[feat] Add listenerName to client config #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryschadler
force-pushed
the
allow-passing-listener-name-to-client-config
branch
from
846a95f to
bc835df
Compare
merlimat
approved these changes
Apr 4, 2024
|
@roryschadler hi, I'm doing release v1.11.0, Do you want to include it in v1.11.0? |
shibd
approved these changes
Apr 6, 2024
shibd
pushed a commit
that referenced
this pull request
Apr 7, 2024
* Allow passing listenerName to client config * Add listener to test conf, e2e test (cherry picked from commit 81ab43d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
Motivation
This library doesn't provide a way to pass a custom listener name to a Pulsar client, which is necessary if you have multiple advertised listeners and want to hit the non-default one: https://pulsar.apache.org/docs/next/concepts-multiple-advertised-listeners/
Modifications
After apache/pulsar-client-cpp#370,
getListenerandsetListenerare now exposed in the C API, and can be used by this library as well.Verifying this change
This change added tests and can be verified as follows:
listenerNameto e2e tests where necessary (uses firstadvertisedListenerby default)Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)